Fix pager test leaks#3238
Merged
Merged
Conversation
kdeldycke
changed the title
Use pytest's ``tmp_path`` fixture instead of a shared ``Path(tempdir) / "pager_out.txt"`` path. The ``tempfile.tempdir`` module global defaults to ``None``, so ``Path(None)`` resolves to the current directory, causing all parallel workers to race on the same file.
kdeldycke
force-pushed
the
fix-pager-test-pollution
branch
from
eb03b2c to
b1bc8c9
Compare
Member
|
Great, this will fix the issue I pointed out at some point where |
Collaborator
Author
|
Thanks @Rowlando13 for the merge! :) |
kdeldycke
added a commit
to kdeldycke/click
that referenced
this pull request
Apr 9, 2026
Add missing entries for pallets#3238 and pallets#3299 Fix wrong version for pallets#3245 changelog entry Lint section format
Collaborator
Author
|
For the record, just added a missing changelog entry in 1339fd3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fix an issue with the
test_echo_via_pagertest, which is polluting other tests and is leaky.This issue was uncovered while playing with parallels and random tests in #3151 (comment) .