Skip to content

Path normalization documentation clean-up + shlex.split extensive tests#3330

Merged
Rowlando13 merged 1 commit into
pallets:stablefrom
kdeldycke:shlex-split-followup
Apr 12, 2026
Merged

Path normalization documentation clean-up + shlex.split extensive tests#3330
Rowlando13 merged 1 commit into
pallets:stablefrom
kdeldycke:shlex-split-followup

Conversation

@kdeldycke
Copy link
Copy Markdown
Collaborator

This is a follow up on #3245, which was merged to stable a bit too early before some documentation issues has been caught.

So this PR:

  • Move all references to issues and PR, as well as developer-centric details, out of their published docstrings and to Python code comments
  • Add some more edge-cases to illustrate the behavior of path normalization
  • Add explicit test cases to demonstrate and verify the behavior of the underlying shlex.split function without posix=False

Also move to Python comments details relevant to developers instead of docstrings
Follow up to pallets#3245
@kdeldycke kdeldycke added the docs label Apr 10, 2026
@kdeldycke kdeldycke added this to the 8.3.3 milestone Apr 10, 2026
@kdeldycke kdeldycke changed the base branch from main to stable April 10, 2026 16:19
@kdeldycke kdeldycke added the f:prompt feature: prompt for input label Apr 10, 2026
@kdeldycke
Copy link
Copy Markdown
Collaborator Author

As you can see in this PR: all cases passes on the 3 platforms, including Windows.

@Rowlando13 Rowlando13 merged commit 4529351 into pallets:stable Apr 12, 2026
12 checks passed
@kdeldycke
Copy link
Copy Markdown
Collaborator Author

Thanks @Rowlando13 for the merge ! :)

@kdeldycke kdeldycke deleted the shlex-split-followup branch April 13, 2026 06:07
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 28, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

docs f:prompt feature: prompt for input

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants