click.get_pager_file: add tests (#1572 followup)#3405
Conversation
click.get_pager_file: add tests (#1572 followup)
kdeldycke
left a comment
There was a problem hiding this comment.
There are workaround and late changes in #1572 about windows so yes, it's better to try to test on that platform too. If you don't have access to a Windows machine, just remove your skip decorator and use the feedback from GitHub workflow runs. Slow, but doable.
…t set color unknowingly.
AndreasBackx
left a comment
There was a problem hiding this comment.
Will still update the change entries, but likely not today.
|
Ah. You're right. Windows runners are failing hard on I also spotted some opportunities to extend the tests with |
|
@AndreasBackx I added a couple of tests around the What do you think of these changes? |
This is a follow-up to #1572 which adds tests to validate the behaviour of
click.get_pager_file. There are still some open-standing questions / todos depending on requirements:catcould we use to create simple tests? We might be able to installcaton our CI, though I haven't looked into it yet.cat-based integration tests. We basically want to make sure that it works how we expect with a real pager, but usingcatseems like the easiest way to validate this as I don't know how we'd test interactive CLIs. 🤔