Travis: use "set -e" to exit script in case of errors #890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blueyed
referenced
this pull request
Nov 12, 2017
* Improve Travis / tox setup Mainly inspired by using pytest directly in tox, for easy test selection etc. * Travis: use lightweight containers (sudo=false) * coverage/codecov integration * include TEST_EXTRA as codecov flag * codecov: -X fix This hopefully works around `complex/complex/commands/__init__.py` and `termui/termui.py` showing up in `examples` (at the root).
Contributor
|
I cherry-picked this into #889 and now it fails as it's supposed to be :) Seems to be working. 👍 |
5 tasks
Contributor
|
@mitsuhiko this really should be merged, because right now the tests are always green, even if they actually fail. According to the contributors page, you did the most commits, that's why I'm mentioning you. |
Contributor
Author
|
Ping @untitaker. |
Contributor
|
Indeed. Agreed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Via b471d34#commitcomment-25568443.