remove abi3 limited api builds#189
Merged
Merged
Conversation
not compatible with the full Unicode API we use
davidism
force-pushed
the
remove-abi3
branch
from
4030d27 to
eb2ba59
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MarkupSafe uses the Python Unicode API, which is mostly unavailable with
Py_LIMITED_API. I don't have the expertise to rewrite the C to be compatible with the limited API, so I'll continue to build version wheels for now. While it would be nice to build fewer wheels with abi3, it's not particularly a problem for me to push a new CI config then upload the new wheels when a new Python version is available.closes #175