-
-
Notifications
You must be signed in to change notification settings - Fork 155
refactor: comply to more ruff and pyright rules #1403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Dr-Irv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it's the case that this makes reportUnusedVariable go away in strict, then you can delete the line in pyproject.toml that refers to it.
cmp0xff
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes are bigger now because two pyright rules are dropped
Dr-Irv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @cmp0xff
Seems like most of the changes are moving from 3.9 compliant code to 3.10. Did you use a tool to make that easier to do?
Hi @Dr-Irv, I used regex to replace in one case, otherwise I used a brute-force approach. |
reportUnusedVariableerrors in the pyright strict testdf.dropsignature does not capture all constraints #950: fixes a remaining issue intest_arguments_dropfrom there