GH1541 Revert Series[Any].__add__(str) #1542
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loicdiridollou
requested review from
Dr-Irv and
cmp0xff
and removed request for
Dr-Irv
Dr-Irv
requested changes
Dec 10, 2025
| # them up. | ||
| @overload | ||
| def __add__(self: Series[Never], other: complex | ListLike) -> Series: ... | ||
| def __add__(self: Series[Never], other: _str | complex | ListLike) -> Series: ... |
Collaborator
There was a problem hiding this comment.
Can you create an overload that says if other: _str, the result is Series[str] ?
cmp0xff
requested changes
Dec 10, 2025
Comment on lines
+4083
to
+4090
|
|
||
|
|
||
| def test_series_add_str() -> None: | ||
| """Test Series.__add__ with Series[Any].""" | ||
| df = pd.DataFrame({0: ["a", "b"]}) | ||
| sr = df[0] | ||
|
|
||
| check(assert_type(sr + "c1", pd.Series), pd.Series, str) |
Contributor
There was a problem hiding this comment.
Plesae move the new test to tests\series\arithmetic\test_add.py and make use of left_str.
Probably we need to make the same valid tests in tests\series\arithmetic\str\test_add.py (excluding the TYPE_CHECKING_INVALID_USAGE ones) work for Series[Any].
For consistency, we probably also need to make Index[Any] + str etc. work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assert_type()to assert the type of any return value)AGENTS.md.