ENH: Improve typing for Period #390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bashtage
force-pushed
the
scalars-period
branch
from
4f195f2 to
8ea5cf3
Compare
Collaborator
|
@bashtage For this and the other new PRs you created, can you click the "request review" item in the PR when you are ready for me to do the review? |
Dr-Irv
requested changes
Oct 19, 2022
Collaborator
Dr-Irv
left a comment
Dr-Irv
left a comment
There was a problem hiding this comment.
I know you may have responded to some of these comments in the original PR, but better to restart the conversation here.
Dr-Irv
requested changes
Oct 20, 2022
bashtage
force-pushed
the
scalars-period
branch
from
969d26d to
643b1cb
Compare
bashtage
force-pushed
the
scalars-period
branch
from
a6674ed to
eafe8ac
Compare
bashtage
force-pushed
the
scalars-period
branch
from
6ca02f0 to
52eab76
Compare
Dr-Irv
reviewed
Oct 22, 2022
Collaborator
Dr-Irv
left a comment
Dr-Irv
left a comment
There was a problem hiding this comment.
I'm fine with everything here, but would like to change __eq__() and __ne__() as described in my comments.
Contributor
Author
|
I think it is ready. I also added |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assert_type()to assert the type of any return valuexref ENH: Improve Pandas scalars #383