Python 3.11 support #435
Python 3.11 support #435
Conversation
bashtage
left a comment
bashtage
left a comment
There was a problem hiding this comment.
Some comments. Would be good to explain why the Python version conditional test with a comment.
|
LGTM. Nightly is just a canary anyway. |
|
@bashtage If you can approve and merge this, then I will do a release. |
|
I don't know if I should mention this as it might delay this being released slightly. |
Thanks for the heads up. I saw your message in time and have pushed changes for |
| - name: Determine poetry version | ||
| shell: bash | ||
| run: echo "::set-output name=VERSION::$(poetry --version)" | ||
| run: echo "{VERSION}=$(poetry --version)" |
There was a problem hiding this comment.
See https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/ . We were getting warnings, and this gets rid of them
4 participants
Before merging, awaiting resolution of pandas-dev/pandas#49736 which I hope will get into pandas 1.5.2, and, if so, we can then remove the warning in
test_frame.py, otherwise we release with it.Putting in draft status for now. Should replace PR #398
Pinned pyright to 1.1.279 and 1.1.280 is reporting errors with relative imports
microsoft/pyright#4212