Skip to content

Conversation

@scari
Copy link
Contributor

@scari scari commented Oct 12, 2015

closes #11080

Worked for this during PyCon JP 2015 pandas sprint /w @sinhrks

I found test_frame.py:TestDataFrame.test_sort_index cover this change.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls add a comment describing what you are doing here and a reference to the issue

@jreback
Copy link
Contributor

jreback commented Oct 12, 2015

pls add some benchmarks that I indicated in the issue (or point to ones that have this covered)

@jreback jreback added Indexing Related to indexing on series/frames, not to indexes themselves Performance Memory or execution speed performance labels Oct 12, 2015
@jreback jreback added this to the 0.17.1 milestone Oct 12, 2015
@scari scari force-pushed the master branch 3 times, most recently from b63024e to fcd592f Compare October 14, 2015 07:24
@scari
Copy link
Contributor Author

scari commented Oct 14, 2015

Added a frame_sort_index test in frame_methods.py

  • 30.96ms 4.64ms 0.15 frame_methods.frame_sort_index.time_frame_sort_index

@jorisvandenbossche
Copy link
Member

@scari I think you did something wrong with rebasing (as there are a lot of other commits here). Can yo do

git fetch upstream
git rebase upstream/master

and then push again.

@scari
Copy link
Contributor Author

scari commented Oct 14, 2015

@jorisvandenbossche Thanks for your kind guidance! I just push again.

jreback added a commit that referenced this pull request Oct 14, 2015
PERF: Checking monotonic-ness before sorting on an index #11080
@jreback jreback merged commit 9bcc1a8 into pandas-dev:master Oct 14, 2015
@jreback
Copy link
Contributor

jreback commented Oct 14, 2015

thanks @scari

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Indexing Related to indexing on series/frames, not to indexes themselves Performance Memory or execution speed performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PERF: checking is_monotonic_increasing/decreasing before sorting on an index

3 participants