Skip to content

BUG GH11693 Support NaT series concatenation #11705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
varunkumar-dev wants to merge 2 commits into from
Closed

BUG GH11693 Support NaT series concatenation #11705

varunkumar-dev wants to merge 2 commits into from

Conversation

@varunkumar-dev
Copy link
Contributor

@varunkumar-dev varunkumar-dev commented Nov 26, 2015

Please review .

Closes #11693

@varunkumar-dev varunkumar-dev force-pushed the fix_NaT_error branch 2 times, most recently from 97c086d to ae8e426 Compare November 26, 2015 03:12
@varunkumar-dev varunkumar-dev changed the title Fix to #11693 BUG GH11693 Support NaT series concatenation Nov 27, 2015
@varunkumar-dev varunkumar-dev force-pushed the fix_NaT_error branch 3 times, most recently from 4cbbd0b to 681cf58 Compare November 27, 2015 05:47
jreback
jreback reviewed Nov 27, 2015
View reviewed changes
pandas/tools/tests/test_merge.py Outdated
Copy link
Contributor

@jreback jreback Nov 27, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use tm.assert_series_equal & construct the expected series

@jreback
Copy link
Contributor

jreback commented Nov 27, 2015

couple comments, pls add a whatsnew note

jreback
jreback reviewed Nov 27, 2015
View reviewed changes
pandas/tools/tests/test_merge.py Outdated
Copy link
Contributor

@jreback jreback Nov 27, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not 100% sure that we have all of these tests, so can you add this for no-tz's as well, and both series all-nat (both with and w/o tz's). use a loop to check all 4 conditions.

Copy link
Contributor

@jreback jreback Nov 27, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

further a concat of tz-aware and (different tz or no tz) should result in object (works, just put all tests in the same place).

Copy link
Contributor

@jreback jreback Nov 27, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we have other tests in merge which test this kind of thing, pls move to a similar location (I don't know if we do)

@jreback jreback added Datetime Datetime data dtype Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate Reshaping Concat, Merge/Join, Stack/Unstack, Explode labels Nov 27, 2015
@jreback jreback added this to the 0.18.0 milestone Nov 27, 2015
@jreback jreback added the Timezones Timezone data dtype label Nov 27, 2015
@jreback jreback mentioned this pull request Dec 3, 2015
Closed
@jreback
Copy link
Contributor

jreback commented Dec 16, 2015

can you update according to comments

@varunkumar-dev
Copy link
Contributor Author

varunkumar-dev commented Dec 17, 2015

apologies for the delay. Will fix over the weekend.

@varunkumar-dev varunkumar-dev force-pushed the fix_NaT_error branch 5 times, most recently from 8b9a0de to 49c4321 Compare December 21, 2015 18:03
@varunkumar-dev varunkumar-dev mentioned this pull request Dec 22, 2015
Closed
jreback
jreback reviewed Jan 8, 2016
View reviewed changes
pandas/tools/merge.py
Copy link
Contributor

@jreback jreback Jan 8, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be fixed solely in _concat_compat

@jreback
Copy link
Contributor

jreback commented Jan 20, 2016

can you update

@jreback
Copy link
Contributor

jreback commented Feb 1, 2016

superseded by #12195

@jreback jreback closed this Feb 1, 2016
@multiloc multiloc mentioned this pull request Feb 19, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Datetime Datetime data dtype Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate Reshaping Concat, Merge/Join, Stack/Unstack, Explode Timezones Timezone data dtype

Projects

None yet

Milestone

0.18.0

Development

Successfully merging this pull request may close these issues.

2 participants

@varunkumar-dev @jreback