BUG: Fixed grow_buffer to grow when capacity is reached #12504
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfyoung
force-pushed
the
read_csv_empty_header
branch
2 times, most recently
from
67aa639 to
3d1078e
Compare
pandas/io/tests/test_parsers.py
Outdated
Contributor
There was a problem hiding this comment.
import the exception (I think its actually imported already though)
Contributor
There was a problem hiding this comment.
scratch that. Why are you catching an exception here at all? These should always be empty frames. In fact you can construct the expected frame and compare
gfyoung
force-pushed
the
read_csv_empty_header
branch
2 times, most recently
from
499d9c5 to
2f8a608
Compare
gfyoung
force-pushed
the
read_csv_empty_header
branch
from
2f8a608 to
8ba3dd0
Compare
Member
Author
|
Tests are passing. Should be good to merge, given how simple the fix was. |
Contributor
|
thank you sir! |
Member
Author
|
Could you also close the associated issue? It doesn't seem to have been closed with the commit you made. |
Contributor
|
hmm, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue in #12494 by allowing
grow_bufferto grow the size of the parser buffer when buffer capacity is achieved. Previously, you had to exceed capacity for this to occur, but that was inconsistent with theend_fieldcheck later on when handling the EOF terminator, where reached capacity was considered a buffer overflow.