Skip to content

Conversation

@OXPHOS
Copy link
Contributor

@OXPHOS OXPHOS commented Mar 17, 2016

Bug fixed from pull request #12327.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pd.crosstab (and same below)

@jreback jreback added Bug Reshaping Concat, Merge/Join, Stack/Unstack, Explode MultiIndex labels Mar 17, 2016
@jreback jreback added this to the 0.18.1 milestone Mar 17, 2016
@OXPHOS
Copy link
Contributor Author

OXPHOS commented Mar 17, 2016

@jreback Thanks for the comments. But I don't think this is the correct way to cherry pick commits..?? I'll learn some github basics and fix this thing within next two days.

@jreback
Copy link
Contributor

jreback commented Mar 17, 2016

@OXPHOS it looks ok. you prob want to squash commits down though to make it easier to work with (e.g. squash yours to a single one, his the same).

@OXPHOS
Copy link
Contributor Author

OXPHOS commented Mar 17, 2016

Cool. Got it. Thanks!

On Thu, Mar 17, 2016 at 12:19 PM, Jeff Reback notifications@github.com
wrote:

@OXPHOS https://github.com/OXPHOS it looks ok. you prob want to squash
commits down though to make it easier to work with (e.g. squash yours to a
single one, his the same).


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#12650 (comment)

@OXPHOS OXPHOS force-pushed the master branch 2 times, most recently from acc85fc to 3acf970 Compare April 12, 2016 19:04
@OXPHOS
Copy link
Contributor Author

OXPHOS commented Apr 13, 2016

@jreback ready to merge : )

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add this to the whatsnew (as a separate bug fix line)

@jreback
Copy link
Contributor

jreback commented Apr 17, 2016

thanks @OXPHOS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug MultiIndex Reshaping Concat, Merge/Join, Stack/Unstack, Explode

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: crosstab with margins=True and dropna=False crosstab dropna=False breaks columns.names

2 participants