Fix/read csv utf aliases #14060
Merged
Fix/read csv utf aliases #14060
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change encoding to lowercase sub - for _ see pandas-dev#13549
test utf-16 and utf-8 caps/ -_ variants see pandas-dev#13549
4 tasks
Member
|
@nateGeorge Now there is only a lint error left (reason for the travis failure): |
Current coverage is 85.27% (diff: 100%)@@ master #14060 diff @@
==========================================
Files 139 139
Lines 50446 50449 +3
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 43018 43021 +3
Misses 7428 7428
Partials 0 0
|
Member
|
@nateGeorge Thanks! |
Contributor
Author
|
Thanks for all the help @jorisvandenbossche ! It was my first contribution to a large open source project and I learned a lot, next time should be much smoother. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
utf-16aliases do not work in read_csv with c engine #13549git diff upstream/master | flake8 --diff-read_csv with engine=c throws error when encoding=UTF_16 (anything other than utf-16)
-improved nosetests and moved to in pandas/io/tests/common.py
-passes
pep8radius upstream/master --diffandgit diff upstream/master | flake8 --diff-put what's new entry in 0.19.0 in accordance with milestone posted on issue