-
-
Notifications
You must be signed in to change notification settings - Fork 19.4k
Skipif no lzma ne #18820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skipif no lzma ne #18820
Conversation
| raise AssertionError("object must be a Series or Index") | ||
|
|
||
| def test_raise_on_panel_with_multiindex(self, parser, engine): | ||
| tm.skip_if_no_ne() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor bug before where this wasn't passing engine as an argument to the skip_if function, so this test was always being skipped on systems lacking numexpr, even for non-numexpr engines
| pd.eval('p + 1', parser=parser, engine=engine) | ||
|
|
||
| def test_raise_on_panel4d_with_multiindex(self, parser, engine): | ||
| tm.skip_if_no_ne() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same bug as above
|
|
||
| @classmethod | ||
| def setup_class(cls): | ||
| super(TestDataFrameEvalPythonPandas, cls).setup_class() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The call to the super setup_class method inadvertently skipped this class of tests on systems that did not have numexpr even though that isn't required for these. Fixed with commit
4e8b6c7 to
0dee6ad
Compare
Codecov Report
@@ Coverage Diff @@
## master #18820 +/- ##
==========================================
- Coverage 91.64% 91.63% -0.02%
==========================================
Files 154 154
Lines 51408 51402 -6
==========================================
- Hits 47113 47100 -13
- Misses 4295 4302 +7
Continue to review full report at Codecov.
|
|
thanks @WillAyd keep em coming! |
git diff upstream/master -u -- "*.py" | flake8 --diff