Skip to content

move shift_months test to test_arithmetic #19636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jreback merged 1 commit into from
Feb 11, 2018
Merged

move shift_months test to test_arithmetic #19636

jreback merged 1 commit into from
Feb 11, 2018

Conversation

@jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented Feb 10, 2018

Broken off of #19627

jreback
jreback approved these changes Feb 10, 2018
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm ping on green

@jreback jreback added the Datetime Datetime data dtype label Feb 10, 2018
@jreback jreback added this to the 0.23.0 milestone Feb 10, 2018
@codecov
Copy link

codecov bot commented Feb 11, 2018 •
edited
Loading

Codecov Report

Merging #19636 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #19636      +/-   ##
==========================================
- Coverage   91.61%   91.59%   -0.03%     
==========================================
  Files         150      150              
  Lines       48807    48807              
==========================================
- Hits        44716    44704      -12     
- Misses       4091     4103      +12
Flag Coverage Δ
#multiple 89.96% <ø> (-0.03%) ⬇️
#single 41.73% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/plotting/_converter.py 65.22% <0%> (-1.74%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13bd008...12e92b8. Read the comment docs.

@jbrockmendel
Copy link
Member Author

jbrockmendel commented Feb 11, 2018

ping

@jreback jreback merged commit cd484cc into pandas-dev:master Feb 11, 2018
@jreback
Copy link
Contributor

jreback commented Feb 11, 2018

thanks

@jbrockmendel jbrockmendel deleted the itests2 branch February 11, 2018 01:29
harisbal pushed a commit to harisbal/pandas that referenced this pull request Feb 28, 2018
@jbrockmendel
move shift_months test to test_arithmetic (pandas-dev#19636)
8433c0e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jreback jreback jreback approved these changes

Assignees

No one assigned

Labels

Datetime Datetime data dtype

Projects

None yet

Milestone

0.23.0

Development

Successfully merging this pull request may close these issues.

2 participants

@jbrockmendel @jreback