DOC: Some doc cleanup #19968
Closed
DOC: Some doc cleanup #19968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topper-123
force-pushed
the
minor_stuff
branch
2 times, most recently
from
01951a6 to
378abb9
Compare
gfyoung
added
Testing
Member
|
I would have preferred that you broke your in PR into two separate PR's: one for the indexing and one for your added tests. It's a little easier to review, and helps to main the atomicity of the PR's / merges. |
Codecov Report
@@ Coverage Diff @@
## master #19968 +/- ##
==========================================
- Coverage 91.71% 91.65% -0.07%
==========================================
Files 150 150
Lines 49104 49049 -55
==========================================
- Hits 45035 44954 -81
- Misses 4069 4095 +26
Continue to review full report at Codecov.
|
topper-123
changed the title
jorisvandenbossche
removed
Missing-data
jreback
requested changes
Mar 5, 2018
doc/source/indexing.rst
Outdated
| .. warning:: | ||
|
|
||
| ``.loc`` is strict when you present slicers that are not compatible (or convertible) with the index type. For example |
Contributor
There was a problem hiding this comment.
acutallly maybe put some of this somewhere in the slicing with labels section.
doc/source/indexing.rst
Outdated
| dfl.loc['20130102':'20130104'] | ||
| .. warning:: | ||
|
|
Contributor
There was a problem hiding this comment.
this part should be left where it was
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some minor stuff regarding
.ixand.loc.1:
The README has a link about
DataFrame.ix. Asixis deprecated, the link is changed to selection-by-label.2:
In selection-by-label a minor wall of warnings come before the reader even knows what the warning are about (because this is the section about `´loc.``...). This is very "scary" introduction.
I've moved the chained-assignment warning to after the intro, and the rest to the end of the section, so the reader first gets an understanding about
locin general and then only after that gets the warnings about the pitfalls ofloc.