Skip to content

Conversation

@charlie0389
Copy link
Contributor

Fixes bug GH19497 - previously, renaming an index with tuples changed its type (i.e. from Index to MultiIndex).

@codecov
Copy link

codecov bot commented May 14, 2018

Codecov Report

Merging #21029 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #21029      +/-   ##
==========================================
- Coverage   91.82%   91.82%   -0.01%     
==========================================
  Files         153      153              
  Lines       49502    49502              
==========================================
- Hits        45457    45455       -2     
- Misses       4045     4047       +2
Flag Coverage Δ
#multiple 90.22% <100%> (-0.01%) ⬇️
#single 41.88% <100%> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/internals.py 95.59% <100%> (ø) ⬆️
pandas/util/testing.py 84.38% <0%> (-0.21%) ⬇️
pandas/io/parsers.py 95.46% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5c02d5...40a53fb. Read the comment docs.

Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, lgtm. can you add a note in bug fixes / indexing section. ping on green.

@jreback jreback added Indexing Related to indexing on series/frames, not to indexes themselves Reshaping Concat, Merge/Join, Stack/Unstack, Explode labels May 14, 2018
@jreback jreback added this to the 0.23.0 milestone May 14, 2018
Copy link
Contributor

@TomAugspurger TomAugspurger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added whatsnew.

@jreback jreback merged commit 46c9656 into pandas-dev:master May 14, 2018
@jreback
Copy link
Contributor

jreback commented May 14, 2018

thanks @charlie0389

@charlie0389
Copy link
Contributor Author

My pleasure :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Indexing Related to indexing on series/frames, not to indexes themselves Reshaping Concat, Merge/Join, Stack/Unstack, Explode

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: rename incapable of accepting tuples as new name

3 participants