Skip to content

Accepts integer/float string with units and raises when unit is ambiguous #21384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Sup3rGeo wants to merge 22 commits into from
Closed

Accepts integer/float string with units and raises when unit is ambiguous #21384

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
7ab9279
Accepts integer/float string with units and raises when unit is ambig…
Jun 8, 2018
98a41f4
Fixed PEP linting.
Jun 8, 2018
23a9834
Updated function signature in pxd file.
Jun 8, 2018
d34140d
Passing tests.
Jun 8, 2018
a2d68e6
Fixed linting.
Jun 8, 2018
521857c
Removed excess space LINT
Jun 8, 2018
d8b7127
Fixed long line.
Jun 9, 2018
0ddbcec
Accepts integer/float string with units and raises when unit is ambig…
Jun 8, 2018
ce94192
Updated function signature in pxd file.
Jun 8, 2018
c590092
Passing tests.
Jun 8, 2018
bb08fc4
Moved whatsnew to 0.24.0.
Sep 30, 2018
2c46d73
Reverted parse_timedelta_string signature.
Sep 30, 2018
298a33c
Checking float with units in Timedelta class.
Sep 30, 2018
677a8f8
Reverted test with exceptions for strings without unit.
Sep 30, 2018
a371472
Useing null context managers from contextlib.
Sep 30, 2018
4669324
Added null context manager for parametrizing tests on exception raising.
Sep 30, 2018
93602ac
Using null context manager from pandas.util.testing.
Sep 30, 2018
28ffc98
Raise when defining units in string and constructor.
Sep 30, 2018
654a0ea
Simplified and added to_timedelta to test.
Sep 30, 2018
f38b4cb
Added debug info to exceptions.
Sep 30, 2018
e322630
Null context manager implementation.
Sep 30, 2018
85f04c9
Updated test.
Sep 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions doc/source/whatsnew/v0.24.0.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -665,8 +665,7 @@ Timedelta
- Bug in :class:`Index` with numeric dtype when multiplying or dividing an array with dtype ``timedelta64`` (:issue:`22390`)
- Bug in :class:`TimedeltaIndex` incorrectly allowing indexing with ``Timestamp`` object (:issue:`20464`)
- Fixed bug where subtracting :class:`Timedelta` from an object-dtyped array would raise ``TypeError`` (:issue:`21980`)
-
-
- Bug in :class:`Timedelta`: where passing a string of a pure number would not take unit into account. Also raises for ambiguous/duplicate unit specification (:issue: `12136`)

Timezones
^^^^^^^^^
Expand Down
Loading