perf improvements in tslibs.period #21447
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrockmendel
commented
Jun 12, 2018
| def _add_delta(self, other): | ||
| if isinstance(other, (timedelta, np.timedelta64, offsets.Tick)): | ||
| offset = frequencies.to_offset(self.freq.rule_code) | ||
| if isinstance(offset, offsets.Tick): |
Member
Author
There was a problem hiding this comment.
This along with the line above is redundant; isinstance(offset, offsets.Tick) if and only if isinstance(self.freq, offsets.Tick).
Codecov Report
@@ Coverage Diff @@
## master #21447 +/- ##
=======================================
Coverage 91.89% 91.89%
=======================================
Files 153 153
Lines 49604 49604
=======================================
Hits 45584 45584
Misses 4020 4020
Continue to review full report at Codecov.
|
gfyoung
added
Datetime
Member
@jbrockmendel : |
jreback
requested changes
Jun 13, 2018
pandas/_libs/tslibs/period.pyx
Outdated
| msg = 'Input cannot be converted to Period(freq={0})' | ||
| raise IncompatibleFrequency(msg.format(self.freqstr)) | ||
| elif isinstance(other, offsets.DateOffset): | ||
| elif getattr(other, "_typ", None) == "dateoffset": |
Contributor
There was a problem hiding this comment.
maybe should add an is_offset_object in util.pxd
Member
Author
|
as isn't showing much (recall it is wonky on my machine for reasons unknown) |
jreback
requested changes
Jun 14, 2018
pandas/_libs/tslibs/period.pyx
Outdated
| msg = 'Input cannot be converted to Period(freq={0})' | ||
| raise IncompatibleFrequency(msg.format(self.freqstr)) | ||
| elif isinstance(other, offsets.DateOffset): | ||
| elif getattr(other, "_typ", None) == "dateoffset": |
jreback
approved these changes
Jun 15, 2018
Contributor
|
thanks! |
david-liu-brattle-1
pushed a commit
to david-liu-brattle-1/pandas
that referenced
this pull request
Jun 18, 2018
Sup3rGeo
pushed a commit
to Sup3rGeo/pandas
that referenced
this pull request
Oct 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes an unnecessary call to
frequencies.to_offset, one of the last few non-cython dependencies in the file.will post asv results when available.