Skip to content

Conversation

@toobaz
Copy link
Member

@toobaz toobaz commented Aug 8, 2018

  • tests passed
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff

Small followup to #22232

@toobaz toobaz force-pushed the df_from_dict_22232_followup branch from fecc07d to a75d57a Compare August 8, 2018 17:29
@toobaz toobaz changed the title CLN: remove redundant calls to ensure_index CLN: remove redundant call to ensure_index Aug 8, 2018
@gfyoung gfyoung added Clean Indexing Related to indexing on series/frames, not to indexes themselves labels Aug 8, 2018
Copy link
Member

@gfyoung gfyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. LGTM.

@jreback jreback added this to the 0.24.0 milestone Aug 9, 2018
@jreback jreback merged commit 91686e6 into pandas-dev:master Aug 9, 2018
@jreback
Copy link
Contributor

jreback commented Aug 9, 2018

thanks @toobaz

@toobaz toobaz deleted the df_from_dict_22232_followup branch August 9, 2018 05:46
Sup3rGeo pushed a commit to Sup3rGeo/pandas that referenced this pull request Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Clean Indexing Related to indexing on series/frames, not to indexes themselves

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants