fixes #22085 (int type pandas.series.index contains float type key bug) #22366
Conversation
a1shadows
changed the title
Codecov Report
@@ Coverage Diff @@
## master #22366 +/- ##
==========================================
- Coverage 92.05% 92.05% -0.01%
==========================================
Files 169 169
Lines 50709 50712 +3
==========================================
+ Hits 46679 46681 +2
- Misses 4030 4031 +1
Continue to review full report at Codecov.
|
jreback
left a comment
jreback
left a comment
There was a problem hiding this comment.
tests and pls add a whatsnew entry for 0.24
pandas/core/indexes/base.py
Outdated
| def __contains__(self, key): | ||
| hash(key) | ||
| try: | ||
| if type(key) == float and self.dtype == int: |
There was a problem hiding this comment.
use is_float(key) and is_integer_dtype(self.dtype)
There was a problem hiding this comment.
I'm sorry, I'm very new to this. But could you please tell me what to add to whatsnew,
jreback
added
Indexing
|
note that this duplicates #22360 |
| try: | ||
| if is_float(key) and is_integer_dtype(self.dtype): | ||
| if key != int(key): | ||
| return False |
There was a problem hiding this comment.
I would put this outside of the try/except block
There was a problem hiding this comment.
@jorisvandenbossche I think it can't pass the test!
There was a problem hiding this comment.
So it fails when key is NaN ?
There was a problem hiding this comment.
I think so. The block is needed.
|
Hello @a1shadows! Thanks for updating the PR. Cheers ! There are no PEP8 issues in this Pull Request. 🍻 Comment last updated on August 16, 2018 at 11:59 Hours UTC |
|
duplicate PR |
5 participants
git diff upstream/master -u -- "*.py" | flake8 --diffchecks for type using is_float, is_integer_dtype and if key is a float that does not resolve to an equivalent int and Index is int, returns false.