Skip to content

Conversation

@datapythonista
Copy link
Member

@datapythonista datapythonista commented Nov 3, 2018

Original work from @JustinZhengBC in #22904. The remote branch does not exist anymore, and I need to create this new PR to rebase.

Merging on green.

@datapythonista datapythonista added Docs Reshaping Concat, Merge/Join, Stack/Unstack, Explode labels Nov 3, 2018
@pep8speaks
Copy link

Hello @datapythonista! Thanks for submitting the PR.

@codecov
Copy link

codecov bot commented Nov 3, 2018

Codecov Report

Merging #23471 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #23471   +/-   ##
=======================================
  Coverage   92.25%   92.25%           
=======================================
  Files         161      161           
  Lines       51207    51207           
=======================================
  Hits        47239    47239           
  Misses       3968     3968
Flag Coverage Δ
#multiple 90.63% <ø> (ø) ⬆️
#single 42.28% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/core/frame.py 97.03% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 528527b...ebe5935. Read the comment docs.

@datapythonista
Copy link
Member Author

This should be ready to be merged.

Copy link
Member

@gfyoung gfyoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this on green! 🎉

@datapythonista datapythonista merged commit d6820ac into pandas-dev:master Nov 7, 2018
JustinZhengBC pushed a commit to JustinZhengBC/pandas that referenced this pull request Nov 14, 2018
tm9k1 pushed a commit to tm9k1/pandas that referenced this pull request Nov 19, 2018
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Docs Reshaping Concat, Merge/Join, Stack/Unstack, Explode

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DOC: Fix the docstring of join in pandas/core/frame.py

4 participants