Skip to content

Conversation

@eoveson
Copy link
Contributor

@eoveson eoveson commented Nov 19, 2018

@pep8speaks
Copy link

Hello @eoveson! Thanks for submitting the PR.

@jreback jreback added Testing pandas testing functions or related to the test suite Period Period data type labels Nov 19, 2018
@codecov
Copy link

codecov bot commented Nov 19, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@c9c9912). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #23776   +/-   ##
=========================================
  Coverage          ?   92.28%           
=========================================
  Files             ?      161           
  Lines             ?    51434           
  Branches          ?        0           
=========================================
  Hits              ?    47467           
  Misses            ?     3967           
  Partials          ?        0
Flag Coverage Δ
#multiple 90.68% <ø> (?)
#single 42.29% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9c9912...4f16c8b. Read the comment docs.

@jreback jreback added this to the 0.24.0 milestone Nov 20, 2018
@jreback jreback merged commit 34e8d52 into pandas-dev:master Nov 20, 2018
@jreback
Copy link
Contributor

jreback commented Nov 20, 2018

thanks @eoveson

Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Period Period data type Testing pandas testing functions or related to the test suite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Lookup using datetimes does not work with hierarchical indices containing periods

4 participants