BUG/ENH - base argument no longer ignored in period resample #23941

ghost · 2018-11-27T05:25:20Z

closes BUG: base argument ignored in PeriodIndex resample #23882
tests added / passed
passes git diff upstream/master -u -- "*.py" | flake8 --diff
whatsnew entry

pep8speaks · 2018-11-27T05:25:22Z

Hello @ArtinSarraf! Thanks for updating the PR.

There are no PEP8 issues in the file pandas/core/resample.py !
There are no PEP8 issues in the file pandas/tests/resample/test_period_index.py !

Comment last updated on December 08, 2018 at 05:00 Hours UTC

codecov · 2018-11-28T02:16:11Z

Codecov Report

Merging #23941 into master will decrease coverage by <.01%.
The diff coverage is 91.3%.

@@            Coverage Diff             @@
##           master   #23941      +/-   ##
==========================================
- Coverage   92.22%   92.22%   -0.01%     
==========================================
  Files         162      162              
  Lines       51785    51805      +20     
==========================================
+ Hits        47758    47776      +18     
- Misses       4027     4029       +2

Flag	Coverage Δ
#multiple	`90.62% <91.3%> (-0.01%)`	⬇️
#single	`42.99% <8.69%> (-0.02%)`	⬇️

Impacted Files	Coverage Δ
pandas/core/resample.py	`96.58% <91.3%> (-0.24%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c037128...c234cac. Read the comment docs.

gfyoung

Good start! Also needs a whatsnew entry.

pandas/tests/resample/test_period_index.py

pandas/core/resample.py

doc/source/whatsnew/v0.24.0.rst

pandas/tests/resample/test_period_index.py

pandas/core/resample.py

doc/source/whatsnew/v0.24.0.rst

pandas/core/resample.py

jreback · 2018-12-04T03:41:11Z

pandas/core/resample.py

+            j = -1 if self.freq.onOffset(end) else None
+
+            labels = binner = PeriodIndex(start=p_start, end=p_end,
+                                      freq=self.freq,


this is a lint error

pandas/core/resample.py

ghost · 2018-12-04T06:51:36Z

@jreback - caught a bug in my original bin offset calculation. Previously it was only valid when the index started at the 0 base of the index's frequency. I've fixed that and added several test cases that previously would have failed.

jreback · 2018-12-05T12:58:09Z

can you merge master

ghost · 2018-12-08T19:48:24Z

@mroeschke - reverted the changes here and added a new PR.
#24159

ghost · 2018-12-09T22:18:50Z

@jreback / @mroeschke - anything else to consider?

doc/source/whatsnew/v0.24.0.rst

pandas/core/resample.py

pandas/tests/resample/test_datetime_index.py

pandas/core/resample.py

jreback

looks good. just want some more docs.

pandas/core/resample.py

jreback · 2018-12-14T14:57:34Z

thanks @ArtinSarraf

…dev#23941)

ENH - account for base argument in period resample

4fbb93c

Artin Sarraf added 5 commits November 27, 2018 01:07

BUG - closer on perfectly emulating previous behavior

ac3f301

BUG - all original resample tests now pass

2a72bac

TST - add preliminary tests for pandas period resample with base

cb03d4e

CLN - pep8 adherence

4833c97

TST - add a couple more tests

5a69414

ghost mentioned this pull request Nov 28, 2018

BUG: base argument ignored in PeriodIndex resample #23882

Closed

gfyoung added Bug Datetime Datetime data dtype Resample resample method labels Nov 28, 2018

gfyoung suggested changes Nov 28, 2018

View reviewed changes

pandas/tests/resample/test_period_index.py Outdated Show resolved Hide resolved

pandas/core/resample.py Outdated Show resolved Hide resolved

Artin Sarraf added 2 commits November 28, 2018 21:03

TST - parameterize tests

5987a2e

DOC- add whatsnew entry

8f3c976

gfyoung reviewed Dec 2, 2018

View reviewed changes

doc/source/whatsnew/v0.24.0.rst Outdated Show resolved Hide resolved

jreback requested changes Dec 3, 2018

View reviewed changes

pandas/tests/resample/test_period_index.py Outdated Show resolved Hide resolved

pandas/core/resample.py Outdated Show resolved Hide resolved

doc/source/whatsnew/v0.24.0.rst Outdated Show resolved Hide resolved

DOC - add comments and modify whatsnew

58a59a6

jreback requested changes Dec 4, 2018

View reviewed changes

doc/source/whatsnew/v0.24.0.rst Outdated Show resolved Hide resolved

pandas/core/resample.py Show resolved Hide resolved

CLN - minor refactor of label creation and whatsnew

6b6d1a9

jreback reviewed Dec 4, 2018

View reviewed changes

pandas/core/resample.py Outdated Show resolved Hide resolved

Artin Sarraf added 5 commits December 3, 2018 23:59

CLN - pep8 adherence

ba10dcf

Merge branch 'master' into bug/period_resample_base

fb1465e

BUG - fix cases where period doesnt start at the 0 base of the freq

b51841a

CLN - remove unneccesary code

5afea5c

CLN - pep8 adherence

5ea4d2c

Merge branch 'master' into bug/period_resample_base

9df9179

CLN - pep8 adherence

c14dbce

Merge branch 'master' into bug/period_resample_base

9bb348a

mroeschke reviewed Dec 9, 2018

View reviewed changes

doc/source/whatsnew/v0.24.0.rst Outdated Show resolved Hide resolved

mroeschke reviewed Dec 9, 2018

View reviewed changes

pandas/core/resample.py Show resolved Hide resolved

mroeschke reviewed Dec 9, 2018

View reviewed changes

pandas/core/resample.py Show resolved Hide resolved

Artin Sarraf added 6 commits December 9, 2018 22:27

TST/DOC - add tests for get range edges and update whatsnew

8e07a95

Merge branch 'master' into bug/period_resample_base

1264f36

Merge branch 'master' into bug/period_resample_base

bca4196

BUG - account for new period diff behavior

0a9c7dc

TST - add test for bad input to get range edges

cfefa36

TST - add one more test case to bad get_range_edges

93eaab7

mroeschke reviewed Dec 12, 2018

View reviewed changes

pandas/tests/resample/test_datetime_index.py Outdated Show resolved Hide resolved

jreback requested changes Dec 12, 2018

View reviewed changes

pandas/core/resample.py Show resolved Hide resolved

pandas/core/resample.py Show resolved Hide resolved

pandas/core/resample.py Show resolved Hide resolved

Artin Sarraf added 2 commits December 12, 2018 19:27

DOC - add docstrings

e5286f8

TST - remove unneccesary test

bef9118

jreback requested changes Dec 13, 2018

View reviewed changes

pandas/core/resample.py Outdated Show resolved Hide resolved

pandas/core/resample.py Outdated Show resolved Hide resolved

pandas/core/resample.py Outdated Show resolved Hide resolved

jreback added this to the 0.24.0 milestone Dec 13, 2018

Artin Sarraf added 3 commits December 12, 2018 22:00

DOC - update docstrings

9b7d261

Merge branch 'master' into bug/period_resample_base

5034455

CLN - rename offset to bin_shift, so as not to confuse with pd.offsets

a49d129

jreback requested changes Dec 13, 2018

View reviewed changes

pandas/core/resample.py Show resolved Hide resolved

pandas/core/resample.py Show resolved Hide resolved

Artin Sarraf added 2 commits December 13, 2018 08:37

DOC - add params and returns sections

8f1e290

Merge branch 'master' into bug/period_resample_base

c234cac

jreback approved these changes Dec 14, 2018

View reviewed changes

jreback merged commit 040f06f into pandas-dev:master Dec 14, 2018

Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019

BUG/ENH - base argument no longer ignored in period resample (pandas-…

c5e8a78

…dev#23941)

Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019

BUG/ENH - base argument no longer ignored in period resample (pandas-…

520e758

…dev#23941)

Uh oh!

BUG/ENH - base argument no longer ignored in period resample #23941

BUG/ENH - base argument no longer ignored in period resample #23941

Uh oh!

Conversation

ghost commented Nov 27, 2018

Uh oh!

pep8speaks commented Nov 27, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Comment last updated on December 08, 2018 at 05:00 Hours UTC

Uh oh!

codecov bot commented Nov 28, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

gfyoung left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jreback Dec 4, 2018

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ghost commented Dec 4, 2018

Uh oh!

jreback commented Dec 5, 2018

Uh oh!

ghost commented Dec 8, 2018

Uh oh!

ghost commented Dec 9, 2018

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jreback left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jreback commented Dec 14, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

pep8speaks commented Nov 27, 2018 •

edited

Loading

codecov bot commented Nov 28, 2018 •

edited

Loading