-
-
Notifications
You must be signed in to change notification settings - Fork 19.4k
DOC: Add dateutil to intersphinx #24437 #24443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…tution decorator in docstrings where commonly repeated
…ugh aggregate method docstrings still have the issue of sharing a docstring with Notes directly after Returns. This means any further appends with a See Also section are out of order.
Codecov Report
@@ Coverage Diff @@
## master #24443 +/- ##
==========================================
+ Coverage 92.3% 92.31% +<.01%
==========================================
Files 163 163
Lines 51977 51977
==========================================
+ Hits 47979 47980 +1
+ Misses 3998 3997 -1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #24443 +/- ##
=======================================
Coverage 92.3% 92.3%
=======================================
Files 163 163
Lines 51977 51977
=======================================
Hits 47979 47979
Misses 3998 3998
Continue to review full report at Codecov.
|
|
did you generate the documentation and checked if the link to the dateutil documentation works? out of curiosity? what order are the intersphinx modules following now? |
|
I generated the documentation and the dateutil link worked okay for example in the pandas.tseries.offsets.DateOffset doc you initially described. The order is now alphabetically listed to make it slightly more legible for reading through the list as it grows and changes. |
datapythonista
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good, but if the order is alphabetical, you may want to have dateutil the first, not the last :)
|
Ah, whoops! I reordered the listing and then added dateutil. Fixed now. |
|
thanks @benjaminr |
|
No probs @jreback |
git diff upstream/master -u -- "*.py" | flake8 --diff