Skip to content

Fixturize tests/frame/test_asof.py #25628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jreback merged 2 commits into from
Mar 10, 2019
Merged

Fixturize tests/frame/test_asof.py #25628

jreback merged 2 commits into from
Mar 10, 2019

Conversation

@h-vetinari
Copy link
Contributor

@h-vetinari h-vetinari commented Mar 10, 2019

Picking up #22471 again. Added one new fixture.

@codecov
Copy link

codecov bot commented Mar 10, 2019

Codecov Report

Merging #25628 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #25628   +/-   ##
=======================================
  Coverage   91.26%   91.26%           
=======================================
  Files         173      173           
  Lines       52968    52968           
=======================================
  Hits        48339    48339           
  Misses       4629     4629
Flag Coverage Δ
#multiple 89.83% <ø> (ø) ⬆️
#single 41.71% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e28ae70...b84dc2f. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 10, 2019 •
edited
Loading

Codecov Report

Merging #25628 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #25628   +/-   ##
=======================================
  Coverage   91.26%   91.26%           
=======================================
  Files         173      173           
  Lines       52968    52968           
=======================================
  Hits        48339    48339           
  Misses       4629     4629
Flag Coverage Δ
#multiple 89.83% <ø> (ø) ⬆️
#single 41.71% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e28ae70...072a2f6. Read the comment docs.

jreback
jreback requested changes Mar 10, 2019
View reviewed changes
pandas/tests/frame/conftest.py Outdated
@pytest.fixture
def date_range_frame():
"""
Fixture for DataFrame of ints with date_range index
Copy link
Contributor

@jreback jreback Mar 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not in love with this as a generalized fixture, if you put in test_asof would be ok

Copy link
Contributor Author

@h-vetinari h-vetinari Mar 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far, the requirement was always that this should be on tests/frame/conftest to be reusable for other test modules. But I don't care either way - can put it into test_asof.py as well.

@jreback jreback added the Testing pandas testing functions or related to the test suite label Mar 10, 2019
@h-vetinari h-vetinari mentioned this pull request Mar 10, 2019
Closed
34 tasks
@h-vetinari
Copy link
Contributor Author

h-vetinari commented Mar 10, 2019

@jreback
Moved the fixture to the test_asof module, and it's green.

@jreback jreback added this to the 0.25.0 milestone Mar 10, 2019
@jreback jreback merged commit a247f80 into pandas-dev:master Mar 10, 2019
@jreback
Copy link
Contributor

jreback commented Mar 10, 2019

thanks

@h-vetinari h-vetinari deleted the fixturize_frame_asof branch March 10, 2019 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jreback jreback jreback approved these changes

Assignees

No one assigned

Labels

Testing pandas testing functions or related to the test suite

Projects

None yet

Milestone

0.25.0

Development

Successfully merging this pull request may close these issues.

2 participants

@h-vetinari @jreback