Skip to content

CLN: Remove inheritance from object in pyx-files #26217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gfyoung merged 1 commit into from
Apr 27, 2019
Merged

CLN: Remove inheritance from object in pyx-files #26217

gfyoung merged 1 commit into from
Apr 27, 2019

Conversation

@topper-123
Copy link
Contributor

@topper-123 topper-123 commented Apr 26, 2019

Continuation of #26128, this time dealing with pyx-files.

WillAyd
WillAyd requested changes Apr 26, 2019
View reviewed changes
ci/code_checks.sh

MSG='Check for python2 new-style classes' ; echo $MSG
invgrep -R --include="*.py" -E "class\s\S*\(object\):" pandas scripts
invgrep -R --include="*.py" --include="*.pyx" -E "class\s\S*\(object\):" pandas scripts
Copy link
Member

@WillAyd WillAyd Apr 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would make sense to just have one include flag like in the other PR

Copy link
Contributor Author

@topper-123 topper-123 Apr 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This follows the conventions of the code_checks.sh file. I also find it more readable than the other convention...

@codecov
Copy link

codecov bot commented Apr 26, 2019

Codecov Report

Merging #26217 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26217      +/-   ##
==========================================
- Coverage   91.97%   91.97%   -0.01%     
==========================================
  Files         175      175              
  Lines       52379    52379              
==========================================
- Hits        48178    48174       -4     
- Misses       4201     4205       +4
Flag Coverage Δ
#multiple 90.52% <ø> (ø) ⬆️
#single 40.7% <ø> (-0.15%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 96.9% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65466f0...a6a4f9e. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Apr 26, 2019 •
edited
Loading

Codecov Report

Merging #26217 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26217      +/-   ##
==========================================
- Coverage   91.97%   91.97%   -0.01%     
==========================================
  Files         175      175              
  Lines       52379    52379              
==========================================
- Hits        48178    48174       -4     
- Misses       4201     4205       +4
Flag Coverage Δ
#multiple 90.52% <ø> (ø) ⬆️
#single 40.7% <ø> (-0.15%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 96.9% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65466f0...a6a4f9e. Read the comment docs.

WillAyd
WillAyd approved these changes Apr 26, 2019
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@gfyoung gfyoung added this to the 0.25.0 milestone Apr 27, 2019
@gfyoung gfyoung merged commit 64104ec into pandas-dev:master Apr 27, 2019
@gfyoung
Copy link
Member

gfyoung commented Apr 27, 2019

Thanks @topper-123 !

@topper-123 topper-123 deleted the remove_inheritance_from_object_II branch April 27, 2019 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WillAyd WillAyd WillAyd approved these changes

Assignees

No one assigned

Labels

Clean

Projects

None yet

Milestone

0.25.0

Development

Successfully merging this pull request may close these issues.

3 participants

@topper-123 @gfyoung @WillAyd