-
-
Notifications
You must be signed in to change notification settings - Fork 19.4k
TST/CLN: Fixturize tests/frame/test_quantile.py #26556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #26556 +/- ##
==========================================
- Coverage 91.77% 91.76% -0.01%
==========================================
Files 174 174
Lines 50649 50649
==========================================
- Hits 46483 46479 -4
- Misses 4166 4170 +4
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #26556 +/- ##
==========================================
- Coverage 91.84% 91.84% -0.01%
==========================================
Files 174 174
Lines 50643 50644 +1
==========================================
- Hits 46515 46512 -3
- Misses 4128 4132 +4
Continue to review full report at Codecov.
|
simonjayhawkins
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@makbigc Thanks for the PR. a couple of suggestions.
|
Yes, close one of the issues there |
OK, have changed to xref #22471. |
666f688 to
ecb0bbb
Compare
simonjayhawkins
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@makbigc lgtm. just the comment regarding the TODO.
simonjayhawkins
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
thanks @makbigc |
git diff upstream/master -u -- "*.py" | flake8 --diff