ASV: remove large IntervalIndex benchmark #26712
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datapythonista
approved these changes
Jun 7, 2019
Member
datapythonista
left a comment
datapythonista
left a comment
There was a problem hiding this comment.
lgtm, thanks for the fix @TomAugspurger
Contributor
Author
|
Hmm travis is not happy. Any objections to me merging this, and following up with CI fixes for travis? |
Member
|
@TomAugspurger a travis build failed, but can't see how to re-run (I used to do it, not sure if travis changed something) I also see that the doc build is failing, I'm taking a look, it was failing because this PR |
Member
|
I'd say that the job failed because the pytest processes were killed, looks like a server problem to me. Happy to get this merged as it is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #26709
The
setupfor thatNtook 30s+ on my machine. I doubt that was intended.