Skip to content

Conversation

@WillAyd
Copy link
Member

@WillAyd WillAyd commented Jun 26, 2019

This was put in place as we were fixing up old annotations but isn't required at this point, so can safely remove and stick with mypy defaults (which is more strict)

@WillAyd WillAyd added the Typing type annotations, mypy/pyright type checking label Jun 26, 2019
@codecov
Copy link

codecov bot commented Jun 26, 2019

Codecov Report

Merging #27048 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #27048      +/-   ##
==========================================
- Coverage      92%      92%   -0.01%     
==========================================
  Files         180      180              
  Lines       50754    50754              
==========================================
- Hits        46698    46695       -3     
- Misses       4056     4059       +3
Flag Coverage Δ
#multiple 90.64% <ø> (ø) ⬆️
#single 41.82% <ø> (-0.1%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 88.88% <0%> (-11.12%) ⬇️
pandas/core/frame.py 96.89% <0%> (-0.12%) ⬇️
pandas/util/testing.py 90.94% <0%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4aa1d6...db3d54d. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jun 26, 2019

Codecov Report

Merging #27048 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #27048      +/-   ##
==========================================
- Coverage      92%      92%   -0.01%     
==========================================
  Files         180      180              
  Lines       50754    50754              
==========================================
- Hits        46698    46695       -3     
- Misses       4056     4059       +3
Flag Coverage Δ
#multiple 90.64% <ø> (ø) ⬆️
#single 41.82% <ø> (-0.1%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 88.88% <0%> (-11.12%) ⬇️
pandas/core/frame.py 96.89% <0%> (-0.12%) ⬇️
pandas/util/testing.py 90.94% <0%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4aa1d6...db3d54d. Read the comment docs.

@jreback jreback added this to the 0.25.0 milestone Jun 27, 2019
@jreback jreback merged commit e955515 into pandas-dev:master Jun 27, 2019
@jreback
Copy link
Contributor

jreback commented Jun 27, 2019

thanks @WillAyd

@WillAyd WillAyd deleted the default-mypy-ci branch January 16, 2020 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Typing type annotations, mypy/pyright type checking

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants