Skip to content

Conversation

@TomAugspurger
Copy link
Contributor

@TomAugspurger
Copy link
Contributor Author

Getting failures like

__________________ TestMethods.test_nargsort[last-expected0] ___________________
[gw1] linux -- Python 3.6.6 /venv/bin/python
self = <pandas.tests.extension.test_categorical.TestMethods object at 0xd6d702ec>
data_missing_for_sorting = [A, NaN, B]
Categories (2, object): [B < A]
na_position = 'last', expected = array([2, 0, 1], dtype=int64)
    @pytest.mark.parametrize('na_position, expected', [
        ('last', np.array([2, 0, 1], dtype='int64')),
        ('first', np.array([1, 2, 0], dtype='int64'))
    ])
    def test_nargsort(self, data_missing_for_sorting, na_position, expected):
        # GH 25439
        result = nargsort(data_missing_for_sorting, na_position=na_position)
>       tm.assert_numpy_array_equal(result, expected)
E       AssertionError: numpy array are different
E       
E       Attribute "dtype" are different
E       [left]:  int32
E       [right]: int64

@jreback jreback added 32bit 32-bit systems Compat pandas objects compatability with Numpy or Python functions labels Jun 27, 2019
@jreback jreback added this to the 0.25.0 milestone Jun 27, 2019
@pytest.mark.parametrize('na_position, expected', [
('last', np.array([2, 0, 1], dtype='int64')),
('first', np.array([1, 2, 0], dtype='int64'))
('last', np.array([2, 0, 1], dtype='int')),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm this is failing on windows, maybe you need intp here?

@codecov
Copy link

codecov bot commented Jun 27, 2019

Codecov Report

Merging #27064 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #27064      +/-   ##
==========================================
- Coverage   92.04%   92.04%   -0.01%     
==========================================
  Files         180      180              
  Lines       50714    50713       -1     
==========================================
- Hits        46679    46677       -2     
- Misses       4035     4036       +1
Flag Coverage Δ
#multiple 90.68% <ø> (ø) ⬆️
#single 41.88% <ø> (-0.07%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 88.88% <0%> (-11.12%) ⬇️
pandas/core/frame.py 96.89% <0%> (-0.12%) ⬇️
pandas/util/testing.py 90.94% <0%> (+0.1%) ⬆️
pandas/core/indexing.py 93.48% <0%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e955515...631be47. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jun 27, 2019

Codecov Report

Merging #27064 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #27064      +/-   ##
==========================================
- Coverage   92.04%   92.04%   -0.01%     
==========================================
  Files         180      180              
  Lines       50714    50713       -1     
==========================================
- Hits        46679    46677       -2     
- Misses       4035     4036       +1
Flag Coverage Δ
#multiple 90.68% <ø> (ø) ⬆️
#single 41.88% <ø> (-0.07%) ⬇️
Impacted Files Coverage Δ
pandas/io/gbq.py 88.88% <0%> (-11.12%) ⬇️
pandas/core/frame.py 96.89% <0%> (-0.12%) ⬇️
pandas/util/testing.py 90.94% <0%> (+0.1%) ⬆️
pandas/core/indexing.py 93.48% <0%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e955515...631be47. Read the comment docs.

@jreback jreback merged commit 1452e71 into pandas-dev:master Jun 27, 2019
@jreback
Copy link
Contributor

jreback commented Jun 27, 2019

thanks @TomAugspurger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

32bit 32-bit systems Compat pandas objects compatability with Numpy or Python functions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants