PERF: do not instantiate IndexEngine for standard lookup over RangeIndex #27119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Jun 29, 2019
toobaz
force-pushed
the
rangeindex_no_engine_16685
branch
from
bc404ba to
493d61f
Compare
jreback
requested changes
Jun 29, 2019
toobaz
force-pushed
the
rangeindex_no_engine_16685
branch
4 times, most recently
from
63cd6ba to
261f43a
Compare
toobaz
force-pushed
the
rangeindex_no_engine_16685
branch
from
261f43a to
3b0b781
Compare
toobaz
force-pushed
the
rangeindex_no_engine_16685
branch
from
3b0b781 to
e9f6f6b
Compare
|
Hello @toobaz! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
|
Member
Author
|
All green. I'm afraid pep8speaks is resenting the heat. |
jreback
added
Indexing
jreback
approved these changes
Jun 30, 2019
Contributor
|
thanks @toobaz nice patch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diffThe
pytest.raises(AttributeError, ...)are somewhat superfluous in that they test a limit of the implementation, rather than a guarantee of the API... but they still make the test more robust.