STYLE: add black makefile & skip some dirs #27231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
| git diff upstream/master --name-only -- "*.py" | xargs flake8 | ||
|
|
||
| black: | ||
| black . --exclude '(asv_bench/env|\.egg|\.git|\.hg|\.mypy_cache|\.nox|\.tox|\.venv|_build|buck-out|build|dist)' |
Member
There was a problem hiding this comment.
Is this to speed up (to prevent black from traversing those dirs)? as some of those dirs should in principle never contain .py files (eg build, .git or .mypy_cache)
Contributor
Author
There was a problem hiding this comment.
no these are black defaults for exclude except for the asv env one
i am unsure whether the defaults are there if u override
Member
There was a problem hiding this comment.
Ah, OK, I see. Yeah, I think it is not additive, so we need to do this .. (for this it would be nice to be able to put this in a pyproject.toml, maybe we should look at that again)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.