BUG: Fix divmod fill value, closes #26987 #27239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Jul 5, 2019
jreback
added
Bug
Missing-data
Contributor
|
this supersedes #27130 right? |
Member
Author
|
yes, but I'm keeping that open because that branch has evolved into addressing other bugs |
4 tasks
jreback
approved these changes
Jul 6, 2019
Contributor
|
thanks @jbrockmendel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diffTakes over from #27130 by implementing dispatch_fill_zeros. This is unfortunately similar to dispatch_missing, and eventually the two functions will be merged. ATM I'm trying to do exactly that in the branch for 27130, having lots of trouble pop up with sparse and IntegerArray.