DOC: Clarify column type for 'on' parameter of rolling #27265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ihsansecer
commented
Jul 6, 2019
ihsansecer
commented
- closes "on" argument of DataFrame.rolling only works for datetime columns #21687
Member
|
Might be reading it wrong but not sure about the referenced issue. Commented there |
jreback
requested changes
Jul 8, 2019
Contributor
jreback
left a comment
jreback
left a comment
There was a problem hiding this comment.
I would rather say that the 'on' argument is ignore for for an integer window argument.
Contributor
Author
|
@WillAyd I believe he is confused if an integer column can be used while calculating rolling window |
jreback
approved these changes
Jul 8, 2019
Contributor
|
thanks @ihsansecer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.