Skip to content

CLN: requested follow-ups #27332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jreback merged 12 commits into from
Jul 11, 2019
Merged

CLN: requested follow-ups #27332

jreback merged 12 commits into from
Jul 11, 2019

Conversation

@jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented Jul 11, 2019

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

jreback
jreback reviewed Jul 11, 2019
View reviewed changes
@jreback jreback added Clean Internals Related to non-user accessible pandas implementation labels Jul 11, 2019
@jreback jreback added this to the 0.25.0 milestone Jul 11, 2019
@jreback
Copy link
Contributor

jreback commented Jul 11, 2019

lgtm. ping on green.

@jbrockmendel
Copy link
Member Author

jbrockmendel commented Jul 11, 2019

ping

@jreback jreback merged commit 8887b1e into pandas-dev:master Jul 11, 2019
@jreback
Copy link
Contributor

jreback commented Jul 11, 2019

thanks!

@jbrockmendel jbrockmendel deleted the follow branch July 11, 2019 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jreback jreback jreback left review comments

Assignees

No one assigned

Labels

Clean Internals Related to non-user accessible pandas implementation

Projects

None yet

Milestone

0.25.0

Development

Successfully merging this pull request may close these issues.

2 participants

@jbrockmendel @jreback