PLT: Delegating to plotting backend only plots of Series and DataFrame methods #27432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Sounds good.
…On Wed, Jul 17, 2019 at 10:45 AM Marc Garcia ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In pandas/plotting/_core.py
<#27432 (comment)>:
> @@ -375,7 +375,7 @@ def boxplot(
>>> type(boxplot)
<class 'numpy.ndarray'>
"""
- plot_backend = _get_plot_backend()
+ plot_backend = _get_plot_backend("matplotlib")
I think this function is pandas.plotting.boxplot(df) and not df.boxplot()
which iirc is boxplot_frame, and in this PR still delegates the call to
the backend.
Personally I'd deprecate pandas.plotting.boxplot more than anything else.
Afaik it's the same as df.boxplot() or df.plot(kind='box'), each with a
different implementation. But if we don't deprecate, my preference would be
to try to make things as simple as possible, and avoid special cases.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#27432?email_source=notifications&email_token=AAKAOIWWMPLROLNDO4SSWNTP745BHA5CNFSM4IERMUL2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB6XUVOA#discussion_r304482395>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAKAOITWMXEKVFIO4XVD5KDP745BHANCNFSM4IERMULQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff