Skip to content

BUG: Fix interpolate ValueError for datetime64_tz index #27549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jreback merged 6 commits into from
Jul 24, 2019
Merged

BUG: Fix interpolate ValueError for datetime64_tz index #27549

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
87ba640
BUG: Fix interpolate ValueError for datetime64_tz index
alorenzo175 Jul 23, 2019
6326908
add change to whatsnew
alorenzo175 Jul 23, 2019
993feb5
remove unused import
alorenzo175 Jul 23, 2019
41e1311
fix whatsnew description
alorenzo175 Jul 23, 2019
9c94eb8
more whatsnew fix
alorenzo175 Jul 23, 2019
a04fec6
parametrize test with tz_naive_fixture
alorenzo175 Jul 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion doc/source/whatsnew/v0.25.1.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ Timezones

Numeric
^^^^^^^
-
- Bug in :meth:`Series.interpolate` when using a timezone aware :class:`DatetimeIndex` (:issue:`27548`)
-
-

Expand Down
3 changes: 1 addition & 2 deletions pandas/core/generic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@
is_bool,
is_bool_dtype,
is_datetime64_any_dtype,
is_datetime64_dtype,
is_datetime64tz_dtype,
is_dict_like,
is_extension_array_dtype,
Expand Down Expand Up @@ -7023,7 +7022,7 @@ def interpolate(
methods = {"index", "values", "nearest", "time"}
is_numeric_or_datetime = (
is_numeric_dtype(index)
or is_datetime64_dtype(index)
or is_datetime64_any_dtype(index)
or is_timedelta64_dtype(index)
)
if method not in methods and not is_numeric_or_datetime:
Expand Down
14 changes: 10 additions & 4 deletions pandas/tests/series/test_missing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1521,10 +1521,16 @@ def test_interp_nonmono_raise(self):
s.interpolate(method="krogh")

@td.skip_if_no_scipy
def test_interp_datetime64(self):
df = Series([1, np.nan, 3], index=date_range("1/1/2000", periods=3))
result = df.interpolate(method="nearest")
expected = Series([1.0, 1.0, 3.0], index=date_range("1/1/2000", periods=3))
@pytest.mark.parametrize("method", ["nearest", "pad"])
Copy link
Contributor

@jreback jreback Jul 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can parametrize on tz_naive_fixture here (and just remove the bottom test); this includes None and a bunch of timezones.

def test_interp_datetime64(self, method, tz_naive_fixture):
df = Series(
[1, np.nan, 3], index=date_range("1/1/2000", periods=3, tz=tz_naive_fixture)
)
result = df.interpolate(method=method)
expected = Series(
[1.0, 1.0, 3.0],
index=date_range("1/1/2000", periods=3, tz=tz_naive_fixture),
)
assert_series_equal(result, expected)

def test_interp_limit_no_nans(self):
Expand Down