Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Jul 24, 2019

#27456 makes for a good regression test for the non-overlapping case, where there's no coverage currently. Add it to the tests.

@pep8speaks
Copy link

pep8speaks commented Jul 24, 2019

Hello @pilkibun! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-07-24 19:33:52 UTC

@jschendel jschendel added Interval Interval data type MultiIndex Testing pandas testing functions or related to the test suite labels Jul 24, 2019
@jschendel jschendel added this to the 1.0 milestone Jul 24, 2019
@jreback jreback merged commit bf8d495 into pandas-dev:master Jul 25, 2019
@jreback
Copy link
Contributor

jreback commented Jul 25, 2019

thanks @pilkibun

@ghost ghost deleted the multindex_regression_test branch July 25, 2019 18:15
quintusdias pushed a commit to quintusdias/pandas_dev that referenced this pull request Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Interval Interval data type MultiIndex Testing pandas testing functions or related to the test suite

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants