added names, fastpath parameters explanation to pandas.Series #27964
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Can you use a more informative title? Looks like a .ipynb file got included accidentally? |
Contributor
Author
|
Yes sure I will do that.
And could you please ignore .ipynb file. It accidently got uploaded.
…Sent from my iPhone
On Aug 17, 2019, at 12:06 PM, jbrockmendel ***@***.***> wrote:
Can you use a more informative title?
Looks like a .ipynb file got included accidentally?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
rmunjal29
changed the title
Member
|
Thanks. We can ignore the extra file for now, but you'll need to remove it before this can be merged. Looks like the lint checker is unhappy about the removed newline. Can you run |
|
Hello @rmunjal29! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2019-11-08 00:20:49 UTC |
WillAyd
requested changes
Aug 26, 2019
Member
WillAyd
left a comment
WillAyd
left a comment
There was a problem hiding this comment.
Minor comments. If you can address and remove the ipynb file should be good to go
pandas/core/series.py
Outdated
| See the :ref:`user guide <basics.dtypes>` for more usages. | ||
| name : str, optional | ||
| The name argument allows to give name to a Series object, i.e. to the column. | ||
| If name isn't given, it will be named automatically. |
Member
There was a problem hiding this comment.
I find this a little unclear - would be better to just remove
Member
|
@rmunjal29 can you merge master and update to comments? |
Contributor
Author
|
Hello William,
Sorry for the late reply. I am actually pretty engaged in my project these days but I will definitely find time and merge these changes.
Thanks and regards,
Ritika
…Sent from my iPhone
On Sep 12, 2019, at 8:34 PM, William Ayd ***@***.***> wrote:
@rmunjal29 can you merge master and update to comments?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Member
|
@rmunjal29 can you address comments? |
Contributor
Author
|
Already updated the changes
Regards,
Ritika
… On Oct 21, 2019, at 8:42 PM, William Ayd ***@***.***> wrote:
@rmunjal29 can you address comments?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Member
|
Looks like there is a notebook in the diff - can you remove that?
…Sent from my iPhone
On Oct 21, 2019, at 7:17 PM, rmunjal29 ***@***.***> wrote:
Already updated the changes
Regards,
Ritika
> On Oct 21, 2019, at 8:42 PM, William Ayd ***@***.***> wrote:
>
>
> @rmunjal29 can you address comments?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub, or unsubscribe.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
WillAyd
approved these changes
Nov 8, 2019
Member
|
Thanks @rmunjal29 |
Reksbril
pushed a commit
to Reksbril/pandas
that referenced
this pull request
Nov 18, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff