CLN: avoid catching Exception in _choose_path #28205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
If you are deep diving on this any chance you can add a docstring for func to help future readers? |
WillAyd
requested changes
Aug 30, 2019
Member
WillAyd
left a comment
WillAyd
left a comment
There was a problem hiding this comment.
minor nit but otherwise lgtm - I think this certainly reads nicer
| if not isinstance(res_fast, DataFrame): | ||
| return path, res | ||
|
|
||
| if not res_fast.columns.equals(group.columns): |
Member
There was a problem hiding this comment.
Can you add this condition to the check above?
Member
Author
There was a problem hiding this comment.
for coverage purposes Id rather leave them separate. i.e. i want to be able to see that both cases are reached
Contributor
|
lgtm. @WillAyd ? |
WillAyd
approved these changes
Sep 2, 2019
Member
|
Thanks @jbrockmendel |
MarcoGorelli
pushed a commit
to MarcoGorelli/pandas
that referenced
this pull request
Sep 3, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff