PERF: asv for import #28239
Merged
PERF: asv for import #28239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Sep 2, 2019
TomAugspurger
approved these changes
Sep 3, 2019
jreback
approved these changes
Sep 4, 2019
Contributor
jreback
left a comment
jreback
left a comment
There was a problem hiding this comment.
very minor comment, merge on green.
| def time_import(self): | ||
| if PY37: | ||
| cmd = [sys.executable, "-X", "importtime", "-c", "import pandas as pd"] | ||
| p = subprocess.run(cmd, stderr=subprocess.PIPE) |
Contributor
There was a problem hiding this comment.
can you add a comment for this as 3.7 actually does the timing, where for < 3.7 asv is doing the timing.
Member
Author
There was a problem hiding this comment.
comment added + green
asv_bench/benchmarks/package.py
Outdated
| return total | ||
|
|
||
| cmd = [sys.executable, "-c", "import pandas as pd"] | ||
| p = subprocess.run(cmd, stderr=subprocess.PIPE) |
Contributor
There was a problem hiding this comment.
is this a lint error to assign to p?
Member
Author
There was a problem hiding this comment.
i think it should be, no idea why it isn't. will fix anyway
Member
|
Thanks @jbrockmendel |
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for py37 this uses
-X importtimeto get a more precise number without subprocess overhead. Doesn't actually do anything with it, but what the heck.Couple of unrelated cleanups.