CLN: Exception and BaseException in test_nanops #28544
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
approved these changes
Sep 20, 2019
Member
WillAyd
left a comment
WillAyd
left a comment
There was a problem hiding this comment.
lgtm. Not sure why that would have been done in the first place
jorisvandenbossche
approved these changes
Sep 20, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AFAICT these are artifacts of pre-pytest usage where we needed to manually add info to the traceback.
Adds a code_check to make sure we aren't catching BaseException anywhere. BaseException includes KeyboardInterrupt, which we shouldn't be catching in general.
Saving parametrization in test_nanops for a separate pass, as the diff will get big.