REF: Assert json roundtrip equal #28626
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add assert_json_roundtrip_equal function to make repeated pattern modular
Replaced repeated code with calls to assert_json_roundtrip_equal
Member
|
This is really nice, thanks. Looks like the linter is finding trailing whitespace that you need to delete |
Remove trailing whitespace
Remove trailing whitespace
WillAyd
requested changes
Sep 27, 2019
Member
WillAyd
left a comment
WillAyd
left a comment
There was a problem hiding this comment.
I think test_roundtrip_intframe is the one outstanding - can you use this function therein as well? After that lgtm can get this merged - thanks for the PR!
Contributor
Author
|
Thank you, yes. I will do that now. |
Remove whitespace
WillAyd
approved these changes
Sep 27, 2019
Member
|
Thanks @bganglia nice PR and great first contribution. Would welcome more PRs to tackle other issues! |
josibake
pushed a commit
to josibake/pandas
that referenced
this pull request
Sep 29, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
bongolegend
pushed a commit
to bongolegend/pandas
that referenced
this pull request
Jan 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces a some frequently repeated lines with a function.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff