CLN: Exception catching in expressions #28650
Merged
+18
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ) | ||
| except ValueError as detail: | ||
| if "unknown type object" in str(detail): | ||
| pass |
Member
There was a problem hiding this comment.
This did never happen?
Member
Author
There was a problem hiding this comment.
the only errors that bubble up are TypeErrors, which we catch in the calling func in ops.array_ops
jreback
requested changes
Sep 27, 2019
| return "bool" in x.dtypes | ||
| else: | ||
| return x.dtype == bool | ||
| return x.dtype == bool |
Contributor
There was a problem hiding this comment.
you can use is_bool_dtype(x) ?
Member
Author
There was a problem hiding this comment.
could, but thats non-performant, which is a big deal here
jreback
approved these changes
Sep 27, 2019
josibake
pushed a commit
to josibake/pandas
that referenced
this pull request
Sep 29, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
bongolegend
pushed a commit
to bongolegend/pandas
that referenced
this pull request
Jan 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.