Clean up Abstract and Naming Definitions for GroupBy #28847
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes:
_iterate_slicesabstract in base class, moved pre-existing definition from Base -> Series where it was actually being called (DataFrame already overrides)_wrap_transformed_outputAbstract in base class, as both Series and DataFrame override this_wrap_applied_output; this was Abstract in base class before but its definition was not in sync with how the subclasses actually defined_wrap_outputto_wrap_series_outputas it is only valid for SeriesGroupBy_wrap_generic_outputto_wrap_frame_outputas it is only valid for DataFrameGroupBy_aggregate_genericto_aggregate_frameas it is only valid for DataFrameGroupByMore to come in separate PRs