Skip to content

TYPING: errors reported by mypy 0.730 #28910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jreback merged 2 commits into from
Oct 11, 2019
Merged

TYPING: errors reported by mypy 0.730 #28910

jreback merged 2 commits into from
Oct 11, 2019

Conversation

@simonjayhawkins
Copy link
Member

@simonjayhawkins simonjayhawkins commented Oct 10, 2019

errors reported by mypy 0.730 on master.

pandas\compat\pickle_compat.py:71: error: Incompatible return type for "__new__" (returns "Series", but must return a subtype of "_LoadSparseSeries")
pandas\compat\pickle_compat.py:85: error: Incompatible return type for "__new__" (returns "DataFrame", but must return a subtype of "_LoadSparseFrame")

probably makes sense to apply these changes now to avoid ci breakage on mypy bump.

@simonjayhawkins simonjayhawkins added the Typing type annotations, mypy/pyright type checking label Oct 10, 2019
@jreback jreback added this to the 1.0 milestone Oct 11, 2019
@jreback jreback merged commit e1e51df into pandas-dev:master Oct 11, 2019
@jreback
Copy link
Contributor

jreback commented Oct 11, 2019

thanks @simonjayhawkins

@simonjayhawkins simonjayhawkins mentioned this pull request Oct 11, 2019
Merged
@simonjayhawkins simonjayhawkins deleted the pickle_compat branch October 11, 2019 13:44
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@simonjayhawkins @proost
TYPING: errors reported by mypy 0.730 (pandas-dev#28910)
356e3ba
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@simonjayhawkins @proost
TYPING: errors reported by mypy 0.730 (pandas-dev#28910)
58e1a5b
bongolegend pushed a commit to bongolegend/pandas that referenced this pull request Jan 1, 2020
@simonjayhawkins
TYPING: errors reported by mypy 0.730 (pandas-dev#28910)
13bf29c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Typing type annotations, mypy/pyright type checking

Projects

None yet

Milestone

1.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@simonjayhawkins @jreback