fix #28926 pandas\api\test_api.py mypy errors #28935
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @yogendrasoni! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2019-10-12 03:46:05 UTC |
WillAyd
requested changes
Oct 11, 2019
simonjayhawkins
requested changes
Oct 11, 2019
Member
simonjayhawkins
left a comment
simonjayhawkins
left a comment
There was a problem hiding this comment.
@yogendrasoni can you also remove the ignore_errors entry for this module from setup.cfg.
added 2 commits
October 12, 2019 03:57
# Conflicts: # pandas/tests/api/test_api.py
simonjayhawkins
requested changes
Oct 11, 2019
added 4 commits
October 12, 2019 05:03
# Conflicts: # pandas/tests/api/test_api.py
simonjayhawkins
approved these changes
Oct 12, 2019
Member
simonjayhawkins
left a comment
simonjayhawkins
left a comment
There was a problem hiding this comment.
@yogendrasoni lgtm @WillAyd
38 tasks
Contributor
Author
@WillAyd , @simonjayhawkins simonjayhawkins anything else is required ? |
WillAyd
approved these changes
Oct 13, 2019
Member
|
Thanks! |
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
…28935) * fix pandas-dev#28926 pandas\api\test_api.py mypy errors * fix pandas-dev#28926 pandas\api\test_api.py mypy errors * changed to type comment to support v 3.5 * removed section mypy-pandas.tests.api.test_api * fix annotation and revert delete * fix import sorting * fix import sorting
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
…28935) * fix pandas-dev#28926 pandas\api\test_api.py mypy errors * fix pandas-dev#28926 pandas\api\test_api.py mypy errors * changed to type comment to support v 3.5 * removed section mypy-pandas.tests.api.test_api * fix annotation and revert delete * fix import sorting * fix import sorting
bongolegend
pushed a commit
to bongolegend/pandas
that referenced
this pull request
Jan 1, 2020
…28935) * fix pandas-dev#28926 pandas\api\test_api.py mypy errors * fix pandas-dev#28926 pandas\api\test_api.py mypy errors * changed to type comment to support v 3.5 * removed section mypy-pandas.tests.api.test_api * fix annotation and revert delete * fix import sorting * fix import sorting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff