ENH: Informative dtype message for for assert_series_equal #28993
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Which whatsnew do I have to change? |
Member
|
If there's nothing user-facing, you dont need a whatsnew entry |
Contributor
Author
|
OK thanks! Then this pull request should be ready to merge. |
Contributor
|
can you merge master. ping when all green. |
moi90
force-pushed
the
assert_series_equal-check_dtype
branch
from
87054b4 to
20026e0
Compare
Member
|
@moi90 can you rebase? the CI failures should be fixed now |
Pass obj to assert_attr_equal in assert_series_equal.
moi90
force-pushed
the
assert_series_equal-check_dtype
branch
from
20026e0 to
a5cfdcd
Compare
Contributor
|
thanks @moi90 |
Contributor
Author
|
You're welcome! |
HawkinsBA
pushed a commit
to HawkinsBA/pandas
that referenced
this pull request
Oct 29, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
proost
pushed a commit
to proost/pandas
that referenced
this pull request
Dec 19, 2019
bongolegend
pushed a commit
to bongolegend/pandas
that referenced
this pull request
Jan 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass obj to assert_attr_equal in assert_series_equal.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffassert_frame_equaldocstring